Upload page improvements #553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some cleanup and modernization of the upload page.
|
@sclv is this PR still ready to go? if so I'd like to pick it up for next weekend's small-change deployment |
hvr
reviewed
Mar 29, 2017
| the old version. | ||
| </li> | ||
| cabal haddock --builddir="$dir" --for-hackage --haddock-option=--hyperlinked-source | ||
| cabal upload -d $dir/*-docs.tar.gz |
There was a problem hiding this comment.
Note that starting with cabal 2.0 one also needs to use the --publish flag to cabal upload (as it defaults to candidates)
hvr
reviewed
Mar 29, 2017
| accepts GHC features, it is also more picky about comment syntax than | ||
| the old version. | ||
| </li> | ||
| cabal haddock --builddir="$dir" --for-hackage --haddock-option=--hyperlinked-source |
|
@hvr I picked up the script from one you proposed. If you'd like to make any changes to it, go for it! |
|
Other than the changes you'd like to make there, I'd be happy to see this deployed. |
|
@gbaz Unfortunately I just realised that this is one of the templates that diverge between the master and central-server branch... which makes this somewhat awkward to merge... :-/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some cleanup and modernization of the upload page.